NO-REF: Fix header when banner is up #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylevillegas93
requested review from
samanthaandrews,
jackiequach,
kristojorg,
Toxiapo and
oliviawongnyc
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ayan1229
approved these changes
Nov 4, 2024
samanthaandrews
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
I think this is ok as a quick fix for now but I wonder if we need to add this to the header repo so that everyone using the header would benefit from this fix. Adding style straight to the div gives me pause. I'll discuss with @jackiequach when she's back.
|
@samanthaandrews ya not super ideal :|. these script based components are a bit tricky to work with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
This PR does the following:
Testing requirements & instructions: